Various fixes to EPUB 3 to DAISY 2.02

bertfrees commented 5 years ago

Addresses the issues https://github.com/daisy/pipeline-scripts/issues/86 and https://github.com/daisy/pipeline-scripts/issues/92.

josteinaj commented 5 years ago

I tried running the test book from the nordic migrator through (C00000.epub), and the result is not valid when I use the Pipeline 1 DAISY 2.02 DTB Validator. I get similar results for our other books. I'm attaching the XML report from Pipeline 1: report.xml.txt

(Also, the "validation" option should probably be a boolean rather than a string option, but that's not really related to this PR.)

bertfrees commented 5 years ago

Thanks for testing. How have you tested it? In your report I'm seeing all the errors that this PR should have fixed.

Why a boolean? It is currently a "choice":

 <choice>
     <value>off</value>
     <a:documentation xml:lang="en">No validation</a:documentation>
     <value>report</value>
     <a:documentation xml:lang="en">Report validation issues</a:documentation>
     <value>abort</value>
     <a:documentation xml:lang="en">Abort on validation issues</a:documentation>
 </choice>

josteinaj commented 5 years ago

Oh, maybe I tested it the wrong way then.

I used the master branch of the super project and created a new local branch
then I ran git subrepo pull modules/scripts --branch super/epub3-to-daisy202
then I changed the scripts-bom version to 1.11.3-SNAPSHOT in the assembly
to make the system build and run I also changed the gui version to 1.2.0 in the assembly, and changed the java version requirement from 11 to 10 in …/bin/pipeline2
then I used make run to start the engine.

boolean/choice: oh, ok. It was a text input field with "off" as the default so I assumed it it would be "on" or "off". Maybe it has an incorrect option type.

bertfrees commented 5 years ago

OK let me push a branch on which you can test it...

Regarding the "validation" option: I'm also seeing this in the web UI now. It looks like the data type is not exposed. Will investigate.

bertfrees commented 5 years ago

@josteinaj Check the epub3-to-daisy202 branch in the super project.

josteinaj commented 5 years ago

I tried the new branch. Still getting errors, but some different errors: report-20190222.xml.txt

bertfrees commented 5 years ago

Thanks. I think the validator from Pipeline 1 is more strict than the one in Pipeline 2. I wonder why. These are the validation issues:

[ ] Attribute ... must be declared for element type 'smil'
[ ] Attribute ... must be declared for element type 'html'
[ ] Invalid pseudo-function (from CSS validation)
[x] File not found: C00000-2-toc.html (in file:/C:/Users/jostein/Desktop/C00000/C00000-01-cover.html)
[ ] required elements missing (in smil files)
[ ] required attributes missing (in smil files)
[ ] bad value for attribute 'name' (in ncc)
[ ] bad value for attribute 'content' (in ncc)
[ ] Could not compare calculated duration to stated duration since this information is missing in the NCC
[ ] NCC schematron: ncc:charset seems not to be in ncc exactly once
[ ] NCC schematron: ncc:pageFront seems not to be in ncc exactly once
[ ] NCC schematron: ncc:pageNormal seems not to be in ncc exactly once
[ ] NCC schematron: dc:identifier seems not to be in ncc exactly once
[ ] NCC schematron: dc:title seems not to be in ncc exactly once
[ ] NCC schematron: ncc:tocItems seems not to be in ncc exactly once
[ ] NCC schematron: ncc:totaltime seems not to be in ncc exactly once

bertfrees commented 5 years ago

File not found: C00000-2-toc.html (in file:/C:/Users/jostein/Desktop/C00000/C00000-01-cover.html)

This one is solved. It was an error in the input EPUB. @rdeltour epubcheck didn't pick this up. See https://github.com/w3c/epubcheck/issues/975

bertfrees commented 5 years ago

@rdeltour Do you think we should make the validator more strict?

bertfrees commented 5 years ago

Merged in https://github.com/daisy/pipeline-modules/commit/98f901d7aa5ad6cd671cda4797513d6ac4e1cfa9 and addressed most of @rdeltour's comments.

bertfrees commented 5 years ago

Yes, this will be the subject of a next PR. This one addresses #86 and #92.

daisy / pipeline-scripts

Various fixes to EPUB 3 to DAISY 2.02 #153