search

daisy / pipeline-scripts

!! NOTE: This project is now part of the pipeline-modules project !! | Script modules for the default DAISY Pipeline 2 distribution.
GNU Lesser General Public License v3.0
6 stars 5 forks source link

Check if the element is among the descendants in moveout #90

Closed capitancambio closed 5 years ago

capitancambio commented 8 years ago

This increases the speed of the algorithm quite dramatically but this is my first foray into the xslt world in several years, so have a deep look. The tests are passing though.

josteinaj commented 8 years ago

LGTM, but I haven't tested it.

@rdeltour feel free to reassign this to me if you're busy. I've started looking through PRs in the three core module repos already and can add this on my TODO as well.

capitancambio commented 8 years ago

@rdeltour is in Prague, so he told me to reassign it. cheers!

bertfrees commented 6 years ago

Looks like this is worth integrating. Javi says it increases the speed dramatically.

capitancambio commented 5 years ago

hello guys! shall we merge this pr? I think this pr is a bit stale by now :rofl:

bertfrees commented 5 years ago

Hi Javi! Yes we should. Thanks for reminding. I will look a bit closer at the XSLT code.

bertfrees commented 5 years ago

I rebased this branch and tested it on the largest DTBook I could find on my computer. It increases the speed a lot indeed. I hope it will improve the issue https://github.com/daisy/pipeline/issues/207.

bertfrees commented 5 years ago

Merged in https://github.com/daisy/pipeline-modules/commit/d9fbbe8