search

daisy / pipeline-scripts

!! NOTE: This project is now part of the pipeline-modules project !! | Script modules for the default DAISY Pipeline 2 distribution.
GNU Lesser General Public License v3.0
6 stars 5 forks source link

html-to-epub3 is broken #93

Closed bertfrees closed 7 years ago

bertfrees commented 7 years ago

since html-to-fileset.xsl was moved to fileset-utils (https://github.com/daisy/pipeline-modules-common/commit/295455937134bd2856eada7f52d5aa39deb2974e).

We didn't notice this because there are no unit tests, so add some.

bertfrees commented 7 years ago

Slightly related: https://github.com/daisy/pipeline-modules-common/commit/ec907b40cc5ef90cad4e61fc8a2ba29e41d9c37c

bertfrees commented 7 years ago

@rdeltour Regarding https://github.com/daisy/pipeline-modules-common/commit/ec907b40cc5ef90cad4e61fc8a2ba29e41d9c37c: do you remember which scripts were broken? If not I think we should first add basic integration tests to all script before reverting your commit, and then see which ones break.

rdeltour commented 7 years ago

Regarding daisy/pipeline-modules-common@ec907b4: do you remember which scripts were broken?

I don't remember specifically, but if I'm not mistaken the name of the new zip steps were changed, so it should be easy to find out by doing a search on the step name.

bertfrees commented 7 years ago

See PR: https://github.com/daisy/pipeline-scripts/compare/bugfix-93