search

daisy / pipeline-tasks

Used for project management of the DAISY Pipeline 2
Apache License 2.0
1 stars 0 forks source link

Source code cleanup/reorganisation #72

Open bertfrees opened 7 years ago

bertfrees commented 7 years ago

February 2017 M

May 2017

April 2018

May 2018

February 2019

Next

I want to do the following two as soon as possible, but first all the PRs in the modules repositories should be merged.

Later XL

Wontfix

Related:

bertfrees commented 7 years ago

@rdeltour Let me know which items you think make sense to do now. None of them are really critical at the moment.

bertfrees commented 7 years ago
  • Remove px:zip-manifest-from-fileset?

@josteinaj You already deleted it in commit https://github.com/daisy/pipeline-modules-common/commit/c95c3505efa6ba3c8da7e1c5c98b5ca072c965bb but then @rdeltour added it back later. It seems that there is similar functionality in fileset-utils/src/main/resources/xml/xslt/fileset-to-zip-manifests.xsl. Is that the reason you removed it at first? There doesn't seem to be an XProc step for it though. px:zip-manifest-from-fileset is currently used in epub3-ocf-utils and odt-utils.

josteinaj commented 7 years ago

@bertfrees Its been a while since I commited that, but I think this is what happened:

I moved the XSLT from zip-utils to fileset-utils to avoid a circular dependency between the two modules.

I also removed px:zip-manifest-from-fileset since it only contained a single XSLT and thus wasn't really needed. Instead I exposed the XSLT through the catalog directly. If you think it makes sense, we could re-add it in fileset-utils (or maybe that's what @rdeltour already did).

bertfrees commented 7 years ago

I think it makes sense to have steps that wrap a single XSLT, if only because you have to write less to invoke it. Romain already re-added it in fileset-utils, yes, in order to fix epub3-ocf-utils and odt-utils). So I guess we don't have to do anything. I just thought there might be another reason why you deleted it. The only thing that bugs me a bit is that there are now two XSLT that seem to do very similar stuff, and I wonder whether they could be merged.

josteinaj commented 7 years ago

Oh I see, there's both fileset-to-zip-manifest.xsl, and fileset-to-zip-manifests.xsl. By the looks of it, the last one seems to be more general, so maybe simply updating the references to this general XSLT and deleting the small XSLT would work.

bertfrees commented 7 years ago

Clearing the milestone for now.

bertfrees commented 6 years ago

In Leipzig we agreed to combine the following repositories into a single repository called "pipeline-modules"

A next step could be to combine all "pipeline-x" repositories, but first we'll see how well this first step works out.

EDIT: The "modules-parent" project should also be moved from pipeline-build-utils to the new pipeline-modules and we could delete all the other parents if we want.

EDIT 2: We can make a common bom for all modules, which can contain 3rd party dependencies common to several module subrepos, like jStyleParser (now included in framework BOM).

bertfrees commented 5 years ago

Good news. It is now possible to transfer issues to other repositories. https://help.github.com/articles/transferring-an-issue-to-another-repository. We can use this to transfer the issues from all the modules repositories to the new "pipeline-modules" repository. We could also use this to transfer issues from the "pipeline" repository to the sub-repositories, or the other way around, move everything to the "pipeline" repository.

bertfrees commented 5 years ago

See PRs

bertfrees commented 5 years ago

See new repo https://github.com/daisy/pipeline-modules

bertfrees commented 5 years ago

See PR https://github.com/daisy/pipeline-modules/pull/5