search

daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
5 stars 2 forks source link

Tray icon size #103

Open bertfrees opened 1 year ago

bertfrees commented 1 year ago

On macOS, the tray icon is two times too large on retina displays.

Some time ago I made a patch that addressed this problem. I need to have a look at it and see if I can make a PR from it. That patch also includes a nicer designed tray icon. It is derived from the known Pipeline icon, but slightly more simplistic. It is also monochromatic like tray icon ought to be on Mac, and the black and white is inverted when clicked. Note that this doesn't change anything for Windows.

bertfrees commented 1 year ago

Does it look like it is supposed to look on Windows?

ways2read commented 1 year ago

Screenshot 2023-03-06 173105 Screenshot of my Windows 11 system tray is attached (hopefully).

ways2read commented 1 year ago

Screenshot 2023-03-06 at 17 39 39 Screenshot from my Mac desktop (not a Retina display) but it shows colored icon whereas most of the others are monochrome.

bertfrees commented 1 year ago

Thanks for the screenshots. OK so it is also too big for you on Mac, while on Windows it looks a little small compared to other icons (the pipes could stick out a bit from the recommended area). I'll create a PR for the Mac part.

bertfrees commented 1 year ago

See https://github.com/daisy/pipeline-ui/pull/111.

marisademeglio commented 1 year ago

See #111.

tested and merged. So this is now just a Windows issue.

NPavie commented 1 year ago

For the windows icon, the problem is that the icon rendering size is fixed by windows. Even if I put a bigger icon, it will still be rendered the same in the tray (in terms of size).

The issue with the icon here is that it has a large part of it transparent, especially on borders due to the "pipes" in the icon

To have a visually more visible icon, we might need to make a more "cropped" version of it (with shorter pipes for example).