search

daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
5 stars 2 forks source link

zoom in keyboard shortcut not working #107

Closed marisademeglio closed 1 year ago

marisademeglio commented 1 year ago

Feedback received: "Zoom In Ctrl + + is not working for me."

"On my PC keyboard the + is on the = key, so I can use ctrl and shift and that key to zoom the content window. In my browser both ctrl and + and ctrl and = will increase the zoom. Also the + on the numeric keypad, but this does not work in the Pipeline app."

marisademeglio commented 1 year ago

More feedback:

" Regarding Zoom in, if i press "CTRL" + "Shift" + "Plus", then it's working fine. On my keyboard Plus and Equal command are on the same key. For "Zoom out" and "Actual Size" commands I don't need to use the Shift key as they(Minus,Zero) are on different keys. "

marisademeglio commented 1 year ago

Another windows user with a combo plus/equals key reports that ctrl + equals does not zoom in.

NPavie commented 1 year ago

Some observations on keyboard shortcuts:

I wanted to change the zoom in and out shortcut to use ctrl+shit++ and ctrl+shift+- (to mimic macos convention on windows) but electron does not allow to use the "-" symbol in shortcuts.

I noticed on several other UIs on Windows that, without a numpad, those shortcuts are simply not working/available, like on edge where you cannot zoom out without a numpad, as the "-" character is bound to number "6" so using the "ctrl+-" shortcut on my keyboard is switching to tab 6 ...

For now, on Windows, I propose to use the following convention to bypass the zoom default shortcuts issue, using the "=" character as zoom modifier :

I expect it should work on most keyboard layouts with a "bottom = | upper +" key (it works on standard AZERTY). The doubt I have is with the QWERTZ layout where the + and = keys are not on the same key and the "=" is bound to shift.

marisademeglio commented 1 year ago

I'm not setup to test this on Windows but on Mac everything still works as it did before with the zoom shortcuts

NPavie commented 1 year ago

The new convention proposed in the commit https://github.com/daisy/pipeline-ui/commit/46d8cfecb9d25910ec056a85a107dd0fd85f1989 is only for windows.

MacOS behavior remains untouched and relyy on ElectronKS default shortcuts.

marisademeglio commented 1 year ago

The new convention proposed in the commit 46d8cfe is only for windows.

MacOS behavior remains untouched and relyy on ElectronKS default shortcuts.

Cool I thought as much, I was just checking for regression bugs.