rdeltour commented 1 year ago

The fix to #82 was to stop opening the window when clicking the tray icon, on macOS. But that means that the only way to show the window now is to use the "New Job" icon, which results in opening a new tab when I don't want a new one, I just wanted to re-open the old tabs.

What about an "Open Window" tray menu item? (that would do what we did previously —still do on Windows— when clicking the tray icon: show the app window).

marisademeglio commented 1 year ago

This sounds reasonable to me

bertfrees commented 1 year ago

The idea of #82 was that when the window would be closed, there would be no jobs open anymore so you if you would open the window without creating a new job (or bring back a job from the background somehow) you would get an empty window.

82 was only done partially though. I think we should either do it properly or disable it for now (hide the setting to configure the tray icon click / close window behavior and change the default).

I'm not against adding an "Open Window" tray menu item, even if it just gives you an empty window. If we add it, it should however only be there depending on the setting to configure the tray icon click / close window behavior.

marisademeglio commented 1 year ago

Right now we have an "open window" tray menu item

daisy / pipeline-ui

show window from the tray icon #114

82 was only done partially though. I think we should either do it properly or disable it for now (hide the setting to configure the tray icon click / close window behavior and change the default).