daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
5 stars 2 forks source link

Window can not be brought back from the tray when application is quit while jobs are running #125

Closed bertfrees closed 1 year ago

bertfrees commented 1 year ago

Very similar to https://github.com/daisy/pipeline-ui/issues/96.

When the application is quit while jobs are running, the window closes and the tray stays active but the window can not be brought back from the tray (all items grey). Only by relaunching the application you can bring the window back, in which case the "Some jobs are still running in the engine" warning will appear.

marisademeglio commented 1 year ago

I can't reproduce this. When I start a big job and quit the application midway through execution, the engine keeps running but the application and tray both exit. And when I restart the app, it starts a new instance of the engine.

Can you give me a step by step recipe?

bertfrees commented 1 year ago

Well you could not reproduce #96 either, so maybe logical that you can't reproduce this one. But I'll add the steps...

bertfrees commented 1 year ago

Steps to reproduce:

All items in tray menu gray.

marisademeglio commented 1 year ago

So with ⌘H, you're hiding the window, but I wouldn't say it's the same as quitting the application (⌘Q).

But still I get different results than you. The tray menu is not ever grayed out again.

Whether I re-enter the application from the mac dock or use the /Applications shortcut, I get a window for the job that's still in progress.

When I try to say Tray->Open Window, nothing happens. But I think that's a different behavior entirely.

bertfrees commented 1 year ago

Sorry! I meant ⌘Q.

marisademeglio commented 1 year ago

Ok! Yet still no luck reproducing, my earlier comment still applies.

NPavie commented 1 year ago

I tried to reproduced the issue :

I'll look into it

NPavie commented 1 year ago

Ok I think I found out how to fix that. It is indeed like for #96 (just a different dialog). I'll fix this behaviour when the window is opened, but in case of quitting the app from the tray with the window already closed, there is no way to change this particular behaviour.

(I think it is macOS default behaviour to block interactions on a app when a dialog not bound to a window is raised, to ensure user does not miss critical inputs)

I'm not sure on why you don't have the dialog displayed every time though, but it might have been placed in a specific workspace.