daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
5 stars 2 forks source link

Engine won't start unless previous version is still installed #126

Closed bertfrees closed 1 year ago

bertfrees commented 1 year ago

This is on macOS. The current version is 1.0.0-RC2 and the previous version is 1.0.0-RC.

If I delete, rename or move the previous version in the trash the engine won't start (there is no Java process). If the previous version is kept were it is, the current version works. I can also delete the previous version and download and install it at the exact same place and it will work too.

marisademeglio commented 1 year ago

Can another mac user comment on this? @rdeltour did you uninstall RC-1 first?

rdeltour commented 1 year ago

Oh damn, yes I can confirm. I just deleted the previous version and the engine won't start…

rdeltour commented 1 year ago

If I remove the "pipeline-ui" directory in "~/Library/Application Support" (after I put the 1.0.0-RC app in the trash) , the engine starts correctly.

marisademeglio commented 1 year ago

@NPavie can you have a look at this one?

NPavie commented 1 year ago

Just to be sure and to check if this happens also on windows, is this the correct reproduction scenario ?

bertfrees commented 1 year ago

Yes

NPavie commented 1 year ago

@marisademeglio i found the problem. I was storing and reusing the pipeline and jre pathes from previous install, it works on windows as the package name had not changed so the application install folder remained the same (but its not the case on macos as app are bundled with their displayed name).

I fixed that by removing the use of the settings' path for this (this was a relicate of when i was testing the use of a system-wide pipeline 2 install with the app).

NPavie commented 1 year ago

Also, this should fix a side effect i had not come to think of : I found out you can launch the app from the DMG, and if i change a setting in this app running from the DMG, it would break the app the same way.

bertfrees commented 1 year ago

Fixed