daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
5 stars 2 forks source link

The "About", "Hide" and "Quit" items do not really need the "(2023)" postfix #134

Closed bertfrees closed 1 year ago

bertfrees commented 1 year ago

Maybe another nit-pick, and others may disagree, but I think the "(2023)" could be used more sparingly as it was only added to be able to make a distinction with Pipeline 1 and the old Pipeline 2 GUI.

On the other hand the "- App" postfix, which was added for a very similar reason, could be used more. Currently it is only used for the window title, but it would also make sense in the dock, in the command-tab list, and in the tray tooltip.

Basically I think whenever the "(2023)" is used the "- App" makes sense, and visa versa.

Anyway, as it's meant to be only a temporary solution it might not be worth our time.

marisademeglio commented 1 year ago

Oh I thought we added (2023) to indicate that this is the latest Pipeline, not for assistive tech. Hope we can fade out this qualifier though.

And the " - App" is for screenreaders who read out window titles but not the window type.

For reference, here are all the places we have the title appear (and I will probably edit this list a lot):

I would prefer in the future to use only "DAISY Pipeline" for everything except the application window title (and maybe the settings & about titles). Those can be " - App".

bertfrees commented 1 year ago

Oh I thought we added (2023) to indicate that this is the latest Pipeline

Right. Mainly to indicate that this is the latest Pipeline. I've updated my comment.

But still, I think that in a lot of cases when the "(2023)" is used the "- App" makes sense, and visa versa.

How I see it:

2023 App
Installer yes maybe
Installed shortcut yes maybe
Dock icon yes maybe
Application window title yes yes
Settings window title yes yes
About box window title yes yes
Tray menu tooltip text yes maybe
Application menu title (mac only) no no
Hide and Quit menu items (mac only) no no
About menu item no no
About box heading maybe no
marisademeglio commented 1 year ago

Putting this under the 1.0 milestone because I'd like to use our (2023) workaround as lightly as possible since we want to move past it in the future.

marisademeglio commented 1 year ago

how about

  2023 App
Installer yes no
Installed shortcut yes no
Dock icon yes no
Application window title yes yes
Settings window title yes yes
About box window title yes yes
Tray menu tooltip text yes no
Application menu title (mac only) no no
Hide and Quit menu items (mac only) no no
About menu item no no
About box heading yes no

Note for the "About box window title"

marisademeglio commented 1 year ago

I do not think there is a way to modify the application menu title without the change affecting the installer, shortcut, etc. So it's going to stay as "DAISY Pipeline (2023)"