search

daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
5 stars 2 forks source link

Make the Github build work again #141

Closed bertfrees closed 10 months ago

bertfrees commented 1 year ago

The build currently fails because for some reason yarn dist tries to authorize to the Github API which results into this error:

GitHub Personal Access Token is not set, neither programmatically, nor using env "GH_TOKEN"

See e.g. https://github.com/daisy/pipeline-ui/actions/runs/4424934667/jobs/7759361961#step:11:10570.

I wonder whether this can be disabled.

bertfrees commented 10 months ago

Was fixed by commit a9e0734f7aec8b99a21e33f8af133a09dfdfe68d by adding this:

env:
  GH_TOKEN: ${{ secrets.GH_PIPELINE_TOKEN }}

@marisademeglio Perhaps we can add a little comment explaining that we don't really understand why, but that it was added to avoid that error message?