search

daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
5 stars 2 forks source link

"Style sheets" option of HTML to braille script does not allow a http URL #143

Closed bertfrees closed 1 year ago

bertfrees commented 1 year ago

Not sure whether this is a UI or a framework bug.

marisademeglio commented 1 year ago

To me it looks like it's an issue with having a text field with an empty pattern attribute which causes the underlying browser engine to apply the :invalid pseudoclass.

Code reference: https://github.com/daisy/pipeline-ui/blob/main/src/renderer/components/Fields/CustomField.tsx#L41

bertfrees commented 1 year ago

I have changed the type of the "stylesheet" option in the latest version. See commit https://github.com/daisy/pipeline-modules/commit/99626f8fbc62d9cea8e1ec56aa20a1b54fdd7f24. Perhaps the issue is fixed now? (Note that it has a type ID with a "xs:" prefix now, so we need that other fix to test it.)

marisademeglio commented 1 year ago

This seems ok to me now

bertfrees commented 1 year ago

Cool

bertfrees commented 1 year ago

Fixed by https://github.com/daisy/pipeline-ui/pull/144