search

daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
6 stars 2 forks source link

If a job request fails, offer to edit the job #157

Closed marisademeglio closed 7 months ago

marisademeglio commented 1 year ago

This would be an enhancement of the current job request error handling, which just reports the error and has a button to close the tab.

There is a state issue with just invoking the "edit job" function, where the error doesn't get cleared on the server side and the UI reads the job data as if it got an error again.

NPavie commented 8 months ago

@marisademeglio i added the functionnality, if you want to test it before closing the issue

(It also helped removing some warning and potential errors reported by my typescript LSP)

marisademeglio commented 7 months ago

The app offers to let me edit the job and try again, but when I resubmit the job, it doesn't pick up my changes. Example, in this video I submit a job with an incorrect filepath, but then when I resubmit it with the filepath corrected, it still shows an error:

https://github.com/daisy/pipeline-ui/assets/734730/32fdfc09-e4b0-4e69-8ee1-cfff5c14dbd2

NPavie commented 7 months ago

Oups, i forgot to remove the error in the job structure when doing the edit. Will push the fix

marisademeglio commented 7 months ago

Looks good here