search

daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
5 stars 2 forks source link

Auto-select first menu item #186

Open marisademeglio opened 5 months ago

marisademeglio commented 5 months ago

From recent tester feedback:

"when open any menu, first menu item inside the menu should be selected"

marisademeglio commented 5 months ago

Is this standard behavior on Windows? @NPavie can you see what happens by default if you alt-F to the file menu in the Pipeline? On mac, the Pipeline behavior matches other native apps, e.g. mac Mail.

NPavie commented 5 months ago

@marisademeglio i checked on several app, and it depends :

I assume that on Windows, on activating the menu, we will need to manually set focus on the first element on opening.

i'll look into that in the app.

NPavie commented 5 months ago

hum this issue might be a bit difficult to solve

I did not find a way so far to force the focus on the first element of the opening menu on opening the menu.

I might look at how vscode does it but i think they overloaded the menu bar creation.

NPavie commented 5 months ago

Opened an issue regarding this in https://github.com/electron/electron/issues/41324

NPavie commented 5 months ago

I did some experiment on electron dev requests as they were not able to reproduce the issue right away and reported to them the results: It seems this selection issue happens when the focus or the mouse is on the web view.

When selecting the application outside the web view (like by switching to the app with alt-tab), the first item of the menu is correctly selected on opening the menu.

avneeshsingh commented 4 months ago

The deadline for final deliverable is close. So, it is OK to defer such minor issues that are taking considerable time. These can be fixed in future releases.