search

daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
5 stars 2 forks source link

Error messages are not user-friendly #204

Closed marisademeglio closed 2 months ago

marisademeglio commented 4 months ago

We received this feedback

  1. On running a Job only by selecting a job with empty textboxes, we get a message "Required jobRequest input port arg(s) missing: source," it should be more user friendly.

  2. On entering a wrong input in Textbox, press Run button, we get a message "Input not found: a relative path was specified but no context provided". There is only a Close job button, nothing to go back and edit the input in the textbox.

marisademeglio commented 4 months ago

In these cases, the error messages come from the engine and are displayed as-is by the UI

bertfrees commented 4 months ago

It sounds like this might be related to https://github.com/daisy/pipeline-ui/issues/30 (job form validation), rather than the engine. Are some of the inputs marked required in the web API? It would be good to know which text boxes they are talking about exactly.

marisademeglio commented 4 months ago

Note: editing a failed job has been added via https://github.com/daisy/pipeline-ui/issues/157

marisademeglio commented 4 months ago

I've discovered something interesting, if you run a job by pressing "run", you get this style of error (HTML form validation):

Screenshot 2024-03-01 at 11 58 22

But if you start the job with Ctrl + R, you get this instead, which is an error coming from the engine:

Screenshot 2024-03-01 at 11 58 10
marisademeglio commented 4 months ago

Need to invoke form validation when Ctrl+R is pressed, instead of submitting the job to the engine

marisademeglio commented 3 months ago

We should probably switch to custom validation that is invoked a deeper level than HTML form validation, and use it everywhere.

marisademeglio commented 2 months ago

Closing this as it will be handled in #218