search

daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
5 stars 2 forks source link

Update to latest engine version 1.14.18-SNAPSHOT #211

Closed bertfrees closed 3 months ago

NPavie commented 3 months ago

@bertfrees this PR breaks the build process on Windows :

There seems to be an issue in the "enable-java-sheel.mk" file in the engine, the ifeq ($(OS),Windows_NT) is not resolved correctly. (when trying to display the content of the "OS" variable seems empty)

I bypass this by forcing the SHELL variable assignment to the correct launcher

bertfrees commented 3 months ago

@NPavie Not sure what could be the problem. The file was changed in https://github.com/daisy/pipeline-assembly/commit/e277f3036f36a17faff6ebe2d9c22bc33e3acc35. The ifeq ($(OS),Windows_NT) did not change.