Most current job status not reflected everywhere when results folder setting is empty

marisademeglio commented 3 months ago

Feedback received from @rachanasinghg " Currently I find the status of pipeline jobs a bit confusing, there is somewhat a difference in the Job title tab and result window. I have attached a few screenshots for your reference.

For example in screenshot DP_Job1 , the result window pane shows Validation completed but the Job tab and status window shows status "Running". Same goes for DP_Job2, DP_Job3 and DP_Job4 screenshot. The last text/sentence of the result pane does not indicate that Job is completed, or the job title tab should show "Completed" instead of "Running". We need to check the result folder whether the file is complete or not. For files which have Error , the title also shows the exact thing so it's good but the other files do not show the same. " DP_Job1 DP_Job2 DP_Job3 DP_Job4

marisademeglio commented 3 months ago

@rachanasinghg does the status in the tab ever get updated to "Completed"?

rachanasinghg commented 3 months ago

@rachanasinghg does the status in the tab ever get updated to "Completed"?

Not till now.

marisademeglio commented 3 months ago

@rachanasinghg does the status in the tab ever get updated to "Completed"?

Not till now.

So it never changes to "Completed"?

Has this always been the case for you or is it new behavior?

rachanasinghg commented 3 months ago

Earlier I used to see the "Completed" status but not after the recent update. Even after running the Job for 12 hours or more it still says "Running". This behaviour was not there in the previous release. Thanks.

With Regards Rachana Singh Usability & Testing Engineer | DAISY Consortium https://daisy.org/activities/software/obi/

On Wed, Apr 3, 2024 at 11:29 PM Marisa DeMeglio @.***> wrote:

@rachanasinghg https://github.com/rachanasinghg does the status in the tab ever get updated to "Completed"?

Not till now.

So it never changes to "Completed"?

Has this always been the case for you or is it new behavior?

— Reply to this email directly, view it on GitHub https://github.com/daisy/pipeline-ui/issues/212#issuecomment-2035255855, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRSLVDDZGTNIWDSWEFXD7DY3Q7RPAVCNFSM6AAAAABFVUXGKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVGI2TKOBVGU . You are receiving this because you were mentioned.Message ID: @.***>

marisademeglio commented 3 months ago

Ok thanks for the clarification! Can you confirm the version that you're using and the version that you were using when it was working?

rachanasinghg commented 3 months ago

Hi Marisa, Currently I am using the following version.

     App version: 1.2.7-RC1,
    Engine version: 1.14.16,
    Engine is running  on 127.0.0.1:49152/ws

Sorry, I am unable to find the previous installer which used to work for me. Let me check again with different installers. Thanks.

With Regards Rachana Singh Usability & Testing Engineer | DAISY Consortium https://daisy.org/activities/software/obi/

On Thu, Apr 4, 2024 at 9:24 PM Marisa DeMeglio @.***> wrote:

Ok thanks for the clarification! Can you confirm the version that you're using and the version that you were using when it was working?

— Reply to this email directly, view it on GitHub https://github.com/daisy/pipeline-ui/issues/212#issuecomment-2037590802, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRSLVC356WFLYLTJQMUCBDY3VZVDAVCNFSM6AAAAABFVUXGKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZXGU4TAOBQGI . You are receiving this because you were mentioned.Message ID: @.***>

marisademeglio commented 2 months ago

Did you have any luck with older installers? Also if these results were with 1.2.7-RC1, maybe we could check with 1.2.7. Can you let me know if that behaves the same?

rachanasinghg commented 2 months ago

Hi Marisa,

I tried both the installers 1.2.7 -RC3 and 1.2.7, but none of them shows jobs as "Completed", either its "Running" or "Error".

With Regards Rachana Singh Usability & Testing Engineer | DAISY Consortium https://daisy.org/activities/software/obi/

On Tue, Apr 16, 2024 at 10:30 PM Marisa DeMeglio @.***> wrote:

Did you have any luck with older installers? Also if these results were with 1.2.7-RC1, maybe we could check with 1.2.7 https://github.com/daisy/pipeline-ui/releases/tag/1.2.7. Can you let me know if that behaves the same?

— Reply to this email directly, view it on GitHub https://github.com/daisy/pipeline-ui/issues/212#issuecomment-2059542065, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRSLVGEBYYER5U7TVMPUR3Y5VKJVAVCNFSM6AAAAABFVUXGKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZGU2DEMBWGU . You are receiving this because you were mentioned.Message ID: @.***>

marisademeglio commented 2 months ago

Ok thanks for testing the other versions, we will look into it. @NPavie do you notice this issue on Windows?

marisademeglio commented 2 months ago

I was not able to reproduce this with the upcoming 1.3.0 release after briefly testing it on Windows 11.

marisademeglio commented 2 months ago

@rachanasinghg Can you check with the new release? And if it's still an issue, could you email your log file found at %APPDATA%\pipeline-ui\logs\main.log ?

rachanasinghg commented 2 months ago

Hi Marisa, I checked the new release pipeline installer and sad to say it is still an issue. I am attaching the log file for your reference. Thank you.

With Regards Rachana Singh Usability & Testing Engineer | DAISY Consortium https://daisy.org/activities/software/obi/

On Tue, Apr 23, 2024 at 9:19 PM Marisa DeMeglio @.***> wrote:

@rachanasinghg https://github.com/rachanasinghg Can you check with the new release https://github.com/daisy/pipeline-ui/releases/tag/1.3.0? And if it's still an issue, could you email your log file found at %APPDATA%\pipeline-ui\logs\main.log ?

— Reply to this email directly, view it on GitHub https://github.com/daisy/pipeline-ui/issues/212#issuecomment-2072787170, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRSLVETSH5DOW4NBF5SBQ3Y6Z7HDAVCNFSM6AAAAABFVUXGKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZSG44DOMJXGA . You are receiving this because you were mentioned.Message ID: @.***>

NPavie commented 2 months ago

Hi @rachanasinghg, sorry about that, we will continue to investigate.

Github did not forwarded the log file along your email for the team to look it up. Can you send it to the team via a separate email to the daisy-pipeline@mail.daisy.org mailing list ?

I notice on the screenshot provided that it was all related to DAISY 2.02 input files, does it also act similarly on other scripts with different input format (like dtbook-based script) ? Along the log file, could it be possible for you to provide us as a zip file of one of the Daisy2.02 book that is exposing this behaviour ?

rachanasinghg commented 2 months ago

Hello @NPavie ,

I have already sent the mail to daisy-pipeline@mail.daisy.org , with 1 Zip file and 2 log files. Zip file has "Alice in wonderland" book which is one of the books throwing errors in conversion. There are 2 log files, file named as old_main contain the Daisy 2 conversion errors, which i had sent through my previous email. The other file named as main_new contains the DAISY 3 conversion errors.

If you are still facing an issue in reading the file, please do let me know. Thank you.

NPavie commented 2 months ago

@rachanasinghg sorry to bother you again, it seems the mail with the attachment did not passed trought the mailing list

Can you try to send it to me to pavie.nicolas@gmail.com ?

rachanasinghg commented 2 months ago

@Nicolas Pavie @.***> I am sorry for the inconvenience caused by the failure of my previous email to reach you.

I have sent 2 separate emails to you, one with the zip file and another with log files. Please check if it reaches you with the attached files, Thanks.

With Regards Rachana Singh Usability & Testing Engineer | DAISY Consortium https://daisy.org/activities/software/obi/

On Wed, Apr 24, 2024 at 8:47 PM Nicolas Pavie @.***> wrote:

@rachanasinghg https://github.com/rachanasinghg sorry to bother you again, it seems the mail with the attachment did not passed trought the mailing list

Can you try to send it to me to @.*** ?

— Reply to this email directly, view it on GitHub https://github.com/daisy/pipeline-ui/issues/212#issuecomment-2075194368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRSLVAPQI2ABOPQT5TH3CDY67EHJAVCNFSM6AAAAABFVUXGKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZVGE4TIMZWHA . You are receiving this because you were mentioned.Message ID: @.***>

marisademeglio commented 2 months ago

@rachanasinghg can you try something? Run a job, wait a bit until when you would expect it to say "completed", and while it still says "running" instead, open this page in a browser:

http://localhost:49152/ws/jobs

and paste the output here. It should be an XML document. It might list nothing or it might list one or more jobs. It can tell us what the pipeline engine is reporting directly, and that might be informative.

NPavie commented 2 months ago

@rachanasinghg from the log I might have an idea of what is going on but just to confirm, can you do the following actions in the application ?

Can you open the application settings, and give us back the value of the "Results folder" setting in the general section ?
Can you select a different result folder using the browse button, close the settings, and then create and launch a new job ?

rachanasinghg commented 2 months ago

Hello Marisa,

Pasting the o/p as you requested. I am getting the Running status for last 3 hours.

This XML file does not appear to have any style information associated with it. The document tree is shown below.

D2-D3_Charles_Dickens

Thanks. With Regards Rachana Singh Usability & Testing Engineer | DAISY Consortium https://daisy.org/activities/software/obi/

On Wed, Apr 24, 2024 at 10:52 PM Marisa DeMeglio @.***> wrote:

@rachanasinghg https://github.com/rachanasinghg can you try something? Run a job, wait a bit until when you would expect it to say "completed", and while it still says "running" instead, open this page in a browser:

http://localhost:49152/ws/jobs

and paste the output here. It should be an XML document. It might list nothing or it might list one or more jobs. It can tell us what the pipeline engine is reporting directly, and that might be informative.

— Reply to this email directly, view it on GitHub https://github.com/daisy/pipeline-ui/issues/212#issuecomment-2075461908, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRSLVGT4E37J2XPYQJFKCLY67S4ZAVCNFSM6AAAAABFVUXGKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZVGQ3DCOJQHA . You are receiving this because you were mentioned.Message ID: @.***>

rachanasinghg commented 2 months ago

Hello Nicolas,

Thank you so much it worked, finally I can see the Complete status.

Regarding your queries , here are my answers under.

Can you open the application settings, and give us back the value of the "Results folder" setting in the general section ? Results folder text box was empty, so no value.
Can you select a different result folder using the browse button, close the settings, and then create and launch a new job ? Through the Browse button I selected a folder path and ran a script. Ultimately the running status was changed to Completed /Error. I am attaching the screenshot.

With Regards Rachana Singh Usability & Testing Engineer | DAISY Consortium https://daisy.org/activities/software/obi/

On Thu, Apr 25, 2024 at 1:04 PM Nicolas Pavie @.***> wrote:

@rachanasinghg https://github.com/rachanasinghg from the log I might have an idea of what is going on but just to confirm, can you do the following actions in the application ?

Can you open the application settings, and give us back the value of the "Results folder" setting in the general section ?

Can you select a different result folder using the browse button, close the settings, and then create and launch a new job ?

— Reply to this email directly, view it on GitHub https://github.com/daisy/pipeline-ui/issues/212#issuecomment-2076555845, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFRSLVH35LMTRPY5DSUITNTY7CWX3AVCNFSM6AAAAABFVUXGKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZWGU2TKOBUGU . You are receiving this because you were mentioned.Message ID: @.***>

NPavie commented 2 months ago

Ok i was able to reproduce the issue i think (it came from the empty value in the Results folder field)

I'll update the issue name

marisademeglio commented 1 month ago

I am having issues with this, if I go under settings and clear the Results folder field, and run a job, it gets stuck mid-process.

What's actually happening is that as soon as the job status is SUCCESS and it attempts to download the results, it says

Error downloading job results TypeError [ERR_INVALID_URL]: Invalid URL

this doesn't happen when the Results folder is set.

12:54:58.761 › fetching  http://127.0.0.1:49152/ws/jobs/b741949c-aaf8-465f-bbd8-8774d651541d null
[1] 12:54:58.777 › received job data  {
[1]   jobId: 'b741949c-aaf8-465f-bbd8-8774d651541d',
[1]   status: 'RUNNING',
[1]   href: 'http://127.0.0.1:49152/ws/jobs/b741949c-aaf8-465f-bbd8-8774d651541d',
[1]   nicename: 'DTBook to braille',
[1]   messages: [ 'removed to keep log cleaner' ],
[1]   progress: 0,
[1]   script: {
[1]     id: 'dtbook-to-pef',
[1]     href: 'http://127.0.0.1:49152/ws/scripts/dtbook-to-pef',
[1]     nicename: 'DTBook to braille',
[1]     description: 'Transforms a DTBook (DAISY 3 XML) document into an embosser ready braille document.',
[1]     version: '10.0.1',
[1]     homepage: '',
[1]     inputs: [],
[1]     options: []
[1]   }
[1] }
[1] 12:54:59.765 › fetching  http://127.0.0.1:49152/ws/jobs/b741949c-aaf8-465f-bbd8-8774d651541d null
[1] 12:54:59.797 › received job data  {
[1]   jobId: 'b741949c-aaf8-465f-bbd8-8774d651541d',
[1]   status: 'SUCCESS',
[1]   href: 'http://127.0.0.1:49152/ws/jobs/b741949c-aaf8-465f-bbd8-8774d651541d',
[1]   nicename: 'DTBook to braille',
[1]   log: 'http://127.0.0.1:49152/ws/jobs/b741949c-aaf8-465f-bbd8-8774d651541d/log',
[1]   results: {
[1]     href: 'http://127.0.0.1:49152/ws/jobs/b741949c-aaf8-465f-bbd8-8774d651541d/result',
[1]     mimeType: 'application/zip',
[1]     namedResults: [ [Object] ]
[1]   },
[1]   messages: [ 'removed to keep log cleaner' ],
[1]   progress: 1,
[1]   script: {
[1]     id: 'dtbook-to-pef',
[1]     href: 'http://127.0.0.1:49152/ws/scripts/dtbook-to-pef',
[1]     nicename: 'DTBook to braille',
[1]     description: 'Transforms a DTBook (DAISY 3 XML) document into an embosser ready braille document.',
[1]     version: '10.0.1',
[1]     homepage: '',
[1]     inputs: [],
[1]     options: []
[1]   }
[1] }
[1] 12:54:59.798 › Error downloading job results TypeError [ERR_INVALID_URL]: Invalid URL
[1]     at new NodeError (node:internal/errors:372:5)
[1]     at URL.onParseError (node:internal/url:553:9)
[1]     at new URL (node:internal/url:629:5)
[1]     at /Users/marisa/dev/pipeline-ui/node_modules/.dev-temp-build/main.js:60147:51
[1]     at Array.map (<anonymous>)
[1]     at /Users/marisa/dev/pipeline-ui/node_modules/.dev-temp-build/main.js:60146:164
[1]     at step (/Users/marisa/dev/pipeline-ui/node_modules/.dev-temp-build/main.js:60030:23)
[1]     at Object.next (/Users/marisa/dev/pipeline-ui/node_modules/.dev-temp-build/main.js:59971:20)
[1]     at asyncGeneratorStep (/Users/marisa/dev/pipeline-ui/node_modules/.dev-temp-build/main.js:59849:28)
[1]     at _next (/Users/marisa/dev/pipeline-ui/node_modules/.dev-temp-build/main.js:59867:17)

marisademeglio commented 1 month ago

I don't know internally what would have to change in order to run jobs with no results folder specified, but it doesn't seem like desirable behavior so I disabled the ability to run jobs if there is not a results folder set in settings.

daisy / pipeline-ui

Most current job status not reflected everywhere when results folder setting is empty #212