daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
5 stars 2 forks source link

Improve configuration for braille-outputting scripts #213

Closed NPavie closed 3 months ago

NPavie commented 3 months ago

This pull request modify braille outputting scripts (ending in to-pef) to use the new stylesheet-parameters endpoint as to complete and/or simplify the scripts settings by relying on user stylesheets.

Closes #198 Closes #207

NPavie commented 3 months ago

Ok i forgot to test some things at first before making the PR but it should now be fixed.

The new UX is as following

The ui then expects a stylesheetParameters with additionnal or modified script options to switch to the second page of the form.

bertfrees commented 3 months ago

I'm not sure if I fully understand, but I will find out by testing it. Will do that as soon as possible.

bertfrees commented 3 months ago

The Windows build failed: https://github.com/daisy/pipeline-ui/actions/runs/8618713899/job/23621741796. I guess this is because of the bug you reported.

bertfrees commented 2 months ago

I was able to fix the build: https://github.com/daisy/pipeline-ui/actions/runs/8628429754

bertfrees commented 2 months ago

@NPavie Testing it now. It does not seem to work when an input XML is given (with a style element in its head), but no style sheets. Is that because of a bug in the engine, or is it because of the UI?

bertfrees commented 2 months ago

Other observations: