Closed NPavie closed 3 months ago
Ok i forgot to test some things at first before making the PR but it should now be fixed.
The new UX is as following
The ui then expects a stylesheetParameters
with additionnal or modified script options to switch to the second page of the form.
stylesheetParameters
field, and
stylesheetParameters
contentI'm not sure if I fully understand, but I will find out by testing it. Will do that as soon as possible.
The Windows build failed: https://github.com/daisy/pipeline-ui/actions/runs/8618713899/job/23621741796. I guess this is because of the bug you reported.
I was able to fix the build: https://github.com/daisy/pipeline-ui/actions/runs/8628429754
@NPavie Testing it now. It does not seem to work when an input XML is given (with a style
element in its head
), but no style sheets. Is that because of a bug in the engine, or is it because of the UI?
Other observations:
@import url(https://raw.githubusercontent.com/daisy/pipeline-modules/master/scripts/html-to-pef/src/main/resources/css/_definition-lists.scss);
, it does work. Not sure whether this is an issue in the engine or UI.The "_definition-lists.scss" style sheet gives me 3 options:
These are auto-generated nice-names. Obviously the descriptions would be better if the Sass variables would have Doxygen comments. What is surprising to me is that the expanded description of these options is "Definition lists" in the three cases. I've spotted a bug in the engine that explains this.
This pull request modify braille outputting scripts (ending in
to-pef
) to use the newstylesheet-parameters
endpoint as to complete and/or simplify the scripts settings by relying on user stylesheets.Closes #198 Closes #207