Engine build issue

[NPavie]

With the latest version of the pipeline merged, I now get the following at the jre building stage :

rm("target/classes");                                \
exec(env("JAVA_HOME", "F:/Nextcloud/Devs/pipeline-ui/engine/src/main/jre/OpenJDK17U-jdk_x64_windows_hotspot_17.0.7_7/jdk-17.0.7+7"),               \
     "mvn.cmd", "-f", "build-jre.xml", "jlink:jlink", "-Pbuild-jre-win64");
[INFO] Scanning for projects...
[INFO] 
[INFO] -----------------------< org.daisy.pipeline:jre >-----------------------
[INFO] Building jre 0.0.0-SNAPSHOT
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- maven-jlink-plugin:3.1.0:jlink (default-cli) @ jre ---
[ERROR] The given project F:\Nextcloud\Devs\pipeline-ui\engine\target\classes does not contain a module-info.java file. So it can't be linked.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.594 s
[INFO] Finished at: 2024-04-17T08:56:58+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-jlink-plugin:3.1.0:jlink (default-cli) on project jre: The given project F:\Nextcloud\Devs\pipeline-ui\engine\target\classes does not contain a module-info.java file. So it can't be linked. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
make[1]: *** [Makefile:488: -Pbuild-jre-win64] Error 1
make[1]: Leaving directory 'F:/Nextcloud/Devs/pipeline-ui/engine'

[NPavie]

Checking the engine develop branch, it seems this commit is breaking the build chain : https://github.com/daisy/pipeline-assembly/commit/8c8149112f83e3efbc6c7d0c970bb63645589bdc

If I revert it, it builds correctly again.

[bertfrees]

Darn

[bertfrees]

Don't know why this suddenly started happening for you. I can't reproduce it. And I thought the rm("target/classes") makes sure this error can not happen. Could you check if the target/classes directory is present? Can you check if this branch works better?

[marisademeglio]

Can we close this - does it work now?

[NPavie]

Seems good to me in my latests tests. I'll close it right now.