search

daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
6 stars 2 forks source link

duplicate jobs created #232

Open marisademeglio opened 5 months ago

marisademeglio commented 5 months ago

Testing feedback from @rachanasinghg for 1.4.0-beta

For image DP_DuplicateJobsCreated , i find when i try to run a particular job, similar jobs are being run in the end, as you can see in the image attached, while running first job named D2_Katie ,6th job is created on its own, i deleted the others with similar name. There were more jobs created whenever I was editing the job.

DP_DuplicateJobsCreated

marisademeglio commented 5 months ago

@rachanasinghg can you give me a recipe to reproduce this in the simplest way possible? E.g. no other jobs going on, and can you email me the source material used? The job log and settings.json file would also be useful to see (settings.json is in C:\Users\<username>\AppData\Roaming\pipeline-ui\settings.json). Email me the files or if you post anything here, make sure to remove sensitive info e.g. TTS API keys.

rachanasinghg commented 5 months ago

Hi Marisa,

Have mailed you the steps and files as requested. Thanks.

Regards Rachana

marisademeglio commented 5 months ago

The issue here is that the user did not expect "Edit job" to create a new tab but to edit the job in an existing tab. But this behavior is intentional and was requested by #130. We may however consider making a note on the "Edit job" button or in the documentation that it will create a new tab.

NPavie commented 5 months ago

@rachanasinghg @marisademeglio note that the original behaviour (edit in place instead of in a new tab) is still possible : We added an "Editing jobs in new tabs" setting to control this in the Settings window under the "Behavior" section.

rachanasinghg commented 5 months ago

Thanks @NPavie , it works now. Nice to know about this checkbox. One more suggestion, it will be good not to open multiple tabs as per Edit job button clicks, 1 or 2 tabs are still ok, so many will surely create confusion. Also, if 2 duplicate tabs are created then they should be side by side, in the first image which i shared named Duplicate job Created, the first job duplicate is created at 6th job position (when user presses the Edit button). It will be great if that can be handled. Thank you.