daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
6 stars 2 forks source link

Improve indication of disabled TTS engines #235

Closed bertfrees closed 3 months ago

bertfrees commented 3 months ago

Currently there is a message underneath the "Key" and "Region" fields saying "Property not set: org.daisy.pipeline.tts.azure.key". This is the message that comes from the engine. From inside the UI this message makes somewhat less sense, and could be improved. I'm not sure exactly how, but we could use the following:

marisademeglio commented 3 months ago

We know that key and, if applicable, region are the required fields for the TTS engines form so we can build in some feedback to the user that they have to be filled in for the connection to work.

marisademeglio commented 3 months ago

I did some work on this, see the test build here https://github.com/daisy/pipeline-ui/actions/runs/9726989779

bertfrees commented 3 months ago

Looks good!