search

daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
6 stars 2 forks source link

Run does not behave the same way from the menu as on the form #244

Closed marisademeglio closed 4 days ago

marisademeglio commented 3 months ago

I originally started looking at this because of an intermittently-reproducible issue and although I found this inconsistency along the way, it is likely not the cause.

marisademeglio commented 3 months ago

That said, I did find major differences in handling job creation:

Form handling (when the button is pressed): https://github.com/daisy/pipeline-ui/blob/main/src/renderer/components/ScriptForm/index.tsx#L172

Menu selection: https://github.com/daisy/pipeline-ui/blob/main/src/main/index.ts#L152

marisademeglio commented 3 months ago

Maybe the "Run" menu command should trigger form submission rather than having onSubmit and menu.run both triggering App.dispatch.