daisy / pipeline-ui

A user interface for the DAISY Pipeline 2
MIT License
5 stars 2 forks source link

There is no "View log" link when an error occured #94

Closed bertfrees closed 1 year ago

bertfrees commented 1 year ago

When an error occurs the need to view the detailed log is the highest.

marisademeglio commented 1 year ago

There is no explicit log link in the XML returned by the Pipeline WS for a job that ended in error:

<job href="http://127.0.0.1:49152/ws/jobs/aae0fc81-a553-4a43-a079-e0ae76a0e99c" id="aae0fc81-a553-4a43-a079-e0ae76a0e99c" status="ERROR">
<nicename>EPUB 3 Validator</nicename>
<script href="http://127.0.0.1:49152/ws/scripts/epub3-validator" id="epub3-validator" input-filesets="epub3">
<nicename>EPUB 3 Validator</nicename>
<description>Validates a EPUB.</description>
<version>2.0.3</version>
</script>
<messages progress="1.0">
<message content="Running EPUBCheck" level="INFO" portion="0.8" progress="1.0" sequence="18" timeStamp="1678127402171">
<message content="Failed to load content types: /Users/marisa/dev/pipeline-ui/node_modules/.dev-temp-build/resources/daisy-pipeline/jre/lib/content-types.properties" level="WARNING" sequence="25" timeStamp="1678127402183"/>
</message>
<message content="null (Please see detailed log for more info.)" level="ERROR" portion="1.0" progress="1.0" sequence="50" timeStamp="1678127402407"/>
</messages>
</job>

I could however infer it from the job url + "/log". It's a little hacky though.

bertfrees commented 1 year ago

OK thanks, I need to fix that.

marisademeglio commented 11 months ago

The workaround in the UI for this Pipeline engine bug has been removed now that the issue is fixed

https://github.com/daisy/pipeline-ui/commit/73be03799e20d37ad23b7e8ba4b4b44978946682#diff-1011daf0ebe69f5e6f5536e82f2f1f5799e61a20999dc3469efc676cf5db4545L26

https://github.com/daisy/pipeline-ui/blob/main/src/renderer/components/JobDetailsPane/index.tsx#L98