search

daisy / transitiontoepub

Repository for developing guidelines, techniques and best practices for accessible EPUB 3
3 stars 6 forks source link

Glossary and links not live added #42

Closed GeorgeKerscher closed 3 months ago

GeorgeKerscher commented 3 months ago

I pasted in the suggestion from Avneesh. The only change there was to ad a ul and li for the term. This is similar to the bibliography.

Also added a paragraph that the links and references are not live.

This will also mean that Gregorio's build of theEPUB should be updated.

gregoriopellegrino commented 3 months ago

Fine for me. When merged, I'll update the EPUB.

GeorgeKerscher commented 3 months ago

I would be happy to use DL, should I make that change and then merge it so we can get this done?

clapierre commented 3 months ago

I think it makes more sense to use DD/DT but I am just wondering if adding DD/DT has their own roles we will be overriding, and by using a list like you did shows this better? What do you think @mattgarrish?

mattgarrish commented 3 months ago

Does the content of the section matter, or are you only testing the dpub-aria roles?

The definitions are supposed to be identifiable within the glossary, so either a list with term and definitions or a definition list works fine in that regard. Definition lists are probably more common, but if you don't care about those roles then it's a coin flip.

clapierre commented 3 months ago

Thanks @mattgarrish we are just testing the dpub-aria roles, so it sounds like we can just leave this as is for now as it isn't that important as Matt says its a coin flip. So lets merge @GeorgeKerscher :)

avneeshsingh commented 3 months ago

Looks good George. It looks that it is ready to go.