search

daisy / xspec-maven-plugin

A Maven plugin for running XSLT unit tests with XSpec
Apache License 2.0
2 stars 0 forks source link

Split up core and plugin, generate index.html #4

Closed bertfrees closed 10 years ago

rdeltour commented 10 years ago

@bertfrees do you have a direct need for splitting the project in submodules ?

Although I don't strongly object, I kinda liked having one single cohesive project, and didn't see an immediate use case for a reusable XSpec runner. Also, I tinkered with a Maven site for the plugin, I don't know how splitting modules impacts that part of the build.

bertfrees commented 10 years ago

Yes I'd really like you to consider this. I want to use the XSpec runner in several places to run tests with Pax-Exam. I have a lot of branches were I'm using it already. It works in combination with the net.sf.saxon.s9api.Processor service provided by saxon-adapter (other PR).

I think it really makes sense to have a reusable XSpec runner. Otherwise I'd have to reimplement quite a bit of your stuff. Another use case I can think of now is an Ant task.

I hope it will not cause problems for building the site, which looks great btw, very useful documentation.

bertfrees commented 10 years ago

Sorry about the last commit, it doesn't build. Did you already check it out, otherwise I'll amend?

rdeltour commented 10 years ago

Yes I'd really like you to consider this. (...) I think it really makes sense to have a reusable XSpec runner.

OK fine, let's do it then :) I've read that the GitHub plugin I use to deploy the site to gh-pages doesn't work well with multi-modules, but I'll keep the site-generation part in the plugin module only, that should work.

Did you already check it out, otherwise I'll amend?

I checked it out, but didn't bring any changes, so go ahead and amend as you like!

rdeltour commented 10 years ago

I squashed the bugfix commit, fixed the last "convenience method" commit to make it build, and added an aggregator POM for the modules. See branch osgi of the project on daisy-consortium/xspec-maven-plugin

bertfrees commented 10 years ago

OK good! thanks