daisybio / drevalpy

GNU General Public License v3.0
2 stars 0 forks source link

Evaluation: Correct calculation of Partial Correlation #13

Closed JudithBernett closed 2 months ago

JudithBernett commented 2 months ago

Right now, it is computed with the pingouin package (partial_corr) but the conditioning on the cell line and drug is done by factorizing the identity. This is wrong, we need a continuous measure where it is okay to interpret it as number. See EFFECT suite for inspiration.