search

daisylb / bridgekeeper

Django permissions, but with QuerySets
https://bridgekeeper.leigh.party/
MIT License
41 stars 14 forks source link

Use __invert__ to implement ~Rule() #10

Closed cpennington closed 4 years ago

cpennington commented 5 years ago

I noticed that ~Attribute(...) didn't work, because you hadn't implemented __invert__. I also made stacking ~ not build up a stack of objects.

cpennington commented 5 years ago

@excitedleigh: Any interest in this change?

daisylb commented 5 years ago

Yep! Just haven't had a chance to look at it properly yet. As you might have noticed I'm actively paying more attention to Bridgekeeper now, so should be able to get to it soon.

cpennington commented 5 years ago

Great!

daisylb commented 5 years ago

So if you want this to land sooner, the only thing that's missing is tests. I can add them myself when I get to it, but if you're able to add some tests that verify the feature works as it should it's less work for me and I can hit merge sooner :)