daisysanson / Game-Marketplace

MIT License
0 stars 0 forks source link

Virtual environments #4

Open Scott3142 opened 3 years ago

Scott3142 commented 3 years ago

You miss a step in your README when setting up virtual environments, which I'm sure you know but would be worth being explicit about.

You say:

To install your virtual environment:

python3 -m pip install --user virtualenv

To run your virtual environment, type in the command line:

source venv/bin/activate

Correction:

To install your virtual environment:

python3 -m pip install --user virtualenv

To create your virtual environment:

virtualenv venv

To run your virtual environment, type in the command line:

source venv/bin/activate

Point of note:

The command source venv/bin/activate only works if you use bash as your shell. If you don't, you need to change this to be source venv/bin/activate.fish or source venv/bin/activate.zsh etc. (Although to be fair, most people who know what it means to change your shell, would know this anyway!)

daisysanson commented 3 years ago

Thanks for pointing this out - I have changed it now! Yes, absolutely - I didn't state that! I was actually unsure whether to include the other options but didn't want to end up writing all the different possibilities. as per .... https://packaging.python.org/guides/installing-using-pip-and-virtual-environments/

I guess I presumed if they read 'you will need virtual environment' and didn't panic, they probably be familiar with shell's and knew to make the changes. Could have included this link above in the README as a solution, I suppose.