daisyui / react-daisyui

daisyUI components built with React 🌼
http://react.daisyui.com/
MIT License
957 stars 103 forks source link

Storybook is broken #326

Closed dev0T closed 1 year ago

dev0T commented 1 year ago

Hello!

I wanted to check the previews on Storybook but apparently, the app isn't working. I mainly use Firefox but attempted to open it on Chrome and got the same result.

Google Chrome:

image

Firefox: image

benjitrosch commented 1 year ago

Hi @dev0T ,

Looks like this was related to upgrading to Storybook v7 this morning (see https://github.com/daisyui/react-daisyui/issues/322).

I managed to fix it for myself by hard refreshing, let me know if that works for you! Not sure yet if it's actually broken or just some weird issue when the old version is cached.

dev0T commented 1 year ago

Unfortunately, I haven't used the Storybook until this afternoon so that wouldn't be the case!

Here are the errors I am getting in the browser console:

image

benjitrosch commented 1 year ago

Ahh, looks like the fix from earlier today that added the .nojekyll file to the /docs folder was overwritten when I re-released. I've added logic to the npm run docs script to create the file every time it runs so that won't happen anymore.

Unfortunately @dev0T that means you will still need to do the hard refresh, still haven't found a way around that. Thanks again for finding this, and sorry again for the outage making it so hard to see the components 😅

Screen Shot 2023-04-04 at 9 13 15 PM
dev0T commented 1 year ago

Thank you @benjitrosch!

I have it working on Chrome. Firefox isn't working no matter what I do though 😅

image

Probably something on my end, I will keep trying

benjitrosch commented 1 year ago

Not just you, I downloaded Firefox and it's happening for me as well. I'll continue to try and maybe open an issue with Storybook if I can't get to the bottom of it!

dev0T commented 1 year ago

I have forked the repo and while running the storybook locally with npm start it is working on Firefox without issues.

Also realized that the deployment preview from my latest PR is working.

benjitrosch commented 1 year ago

Yeah unfortunately the problem only happens on GItHub Pages, but not locally or on Netlify. Seems other users report the exact same thing. Makes the problem very hard to fix and very easy to miss until it's too late 😢

dev0T commented 1 year ago

Yeah unfortunately the problem only happens on GItHub Pages, but not locally or on Netlify. Seems other users report the exact same thing. Makes the problem very hard to fix and very easy to miss until it's too late 😢

Looks like it is broken again on Chrome today. Hard reload isn't working unfortunately

Error is different though:

image

benjitrosch commented 1 year ago

Yikes. I'm going to prioritize fixing this over the weekend, not a great look for the library!

dev0T commented 1 year ago

I did a bit of research but couldn't find anything related that could help. :disappointed:

I don't know what is being used to build Storybook for github pages, but if I could guess I'd say the issue is there

benjitrosch commented 1 year ago

Finally working for me on Safari after changing how pages are built but still no luck on Firefox.

rowlul commented 1 year ago

Still borked on Firefox, but works as expected on Chrome.

samuelkarani commented 1 year ago

Still broken

samuelkarani commented 1 year ago

Broken again

Screenshot 2023-04-12 at 22 52 45
benjitrosch commented 1 year ago

Opened an issue in the storybook repo, hopefully they can offer more insight: https://github.com/storybookjs/storybook/issues/22094

benjitrosch commented 1 year ago

As a temporary fix to bring the Storybook deployment back online, I've reverted the /docs folder to release 3.0.3.

dev0T commented 1 year ago

@benjitrosch I was going to suggest that since my research was directing me to Storybooks issues all the time! Hopefully someone can help with a solution

dev0T commented 1 year ago

@benjitrosch I don't know what happened but its working

image

benjitrosch commented 1 year ago

@dev0T That's the old deployment unfortunately, which means we can't release a new version without breaking it again 😅

dev0T commented 1 year ago

I will be closing this since it appears the issue has been fixed.