daisyui / react-daisyui

daisyUI components built with React 🌼
http://react.daisyui.com/
MIT License
905 stars 101 forks source link

Circular Dependency in ChatBubbleAvatar #329

Closed dev0T closed 1 year ago

dev0T commented 1 year ago

While getting familiar with the library codebase I realized a message regarding a Circular Dependency when running npm run dist:

Circular dependency: src/index.ts -> src/ChatBubble/index.ts -> src/ChatBubble/ChatBubble.tsx -> src/ChatBubble/ChatBubbleAvatar.tsx -> src/index.ts

This is caused by the ChatBubbleAvatar importing Avatar from src/index.ts instead of src/Avatar.

The current import looks like this:

import { Avatar, AvatarProps } from '..'

When they should be:

import Avatar, { AvatarProps } from '../Avatar'

I am making a PR to fix it right now.

benjitrosch commented 1 year ago

Thanks for finding this, approved the PR!