Range component ticks fix

daisyui / react-daisyui

daisyUI components built with React 🌼

http://react.daisyui.com/

MIT License

886 stars 98 forks source link

Closed itaiperi closed 6 months ago

itaiperi commented 6 months ago

This PR fixes #437.

In a nutshell:

The problem - the Range component ticks math is wrong, only takes into account range [0, 100] and no step sizes < 1. Also, ticks are always displayed when step is provided, whether you want to or not.
The suggested fix - add displayTicks and ticksStep parameters to control when to display ticks, and what the ticks step size should be, which can now be different than step (before, they were the same by design). Also, take into account props.min and props.max to allow for the range the user intended in the ticks.

netlify[bot] commented 6 months ago

Name	Link
Latest commit	c3079257f12164e24d6f213afb90873004bcfc88
Latest deploy log	https://app.netlify.com/sites/react-daisyui/deploys/65906fadf9ee9c0008c126d1

netlify[bot] commented 6 months ago

Name	Link
Latest commit	f9fe9a55fb1c02a71a8043eae06b6e2f4e8ad44a
Latest deploy log	https://app.netlify.com/sites/react-daisyui/deploys/65907d819041bd000894a877
Deploy Preview	https://deploy-preview-438--react-daisyui.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 6 months ago

Name	Link
Latest commit	c3079257f12164e24d6f213afb90873004bcfc88
Latest deploy log	https://app.netlify.com/sites/react-daisyui/deploys/65906fadf9ee9c0008c126d1

itaiperi commented 6 months ago

Also, removed usage of useMemo, as there's no actual use for it, and the computation is fairly simple