search

daitj / gnome-display-brightness-ddcutil

Display brightness slider for gnome shell using ddcutil backend
GNU General Public License v3.0
308 stars 38 forks source link

Add setting for ddcutil binary path #93

Closed ryanfitzsimon closed 1 year ago

ryanfitzsimon commented 1 year ago

This allows the extension to work on systems with ddcutil installed in locations other than /usr/bin/ddcutil.

daitj commented 1 year ago

What about just using ddcutil as binary path, then it is upto the user to have ddcutil in their PATH?

ryanfitzsimon commented 1 year ago

That would work fine for me personally (it's actually what I'm entering as the value for this setting).

I was concerned that it might break things for users that currently have /usr/bin/ddcutil on their system, but don't have it on their path for whatever reason. The extension would stop working when they upgrade, which could be frustrating even if the fix is straightforward.

Being able to easily specify the binary would also be nice for someone experimenting with different ddcutil builds, but I imagine that's a pretty niche use case.

daitj commented 1 year ago

I will merge it, since you did the work already, it would be a waste.