daitss / core

DAITSS: Dark Archive In The Sunshine State
GNU General Public License v3.0
9 stars 2 forks source link

web submission gives "Internal Server Error" on zip files produced by Windows XP #414

Closed lydiam closed 13 years ago

lydiam commented 13 years ago

Ilana compressed a folder using Window XP's compression option, but web submission to ripple gave her an "Internal Server Error". From what I can determine it doesn't support AES-256 encryption, which is what I believe WinZip uses and D2 understands.

To be user-friendly, it seems to me that D2 should accept Windows compression .zip files.

childree commented 13 years ago

If she retried, would it still give this error?

lydiam commented 13 years ago

I got the same error when I tried to submit her file from my workstation. I'm not sure why retrying would make a difference. Ilana is able to successfully submit a Winzip file from her workstation. I retried her package at my workstation and got the same error the second time.

avatar382 commented 13 years ago

This isn't a limitation of DAITSS, rather the unix unzip utility, which is what DAITSS is using under the covers. We could have the sysadmins replace it with a more compatible version.

lydiam commented 13 years ago

Ilana seems to have resolved the problem: she was not compressing/zipping a folder. She found that submitting individual files and other non-SIP materials always gave the "Internal Server Error" message. This should probably be changed to something more meaningful. How much control do we have over error messages?

lydiam commented 13 years ago

Something we might consider: instead of saying "packages must be in tar or zip format" we might say "packages must be folders or directories in zip format", or perhaps even point users at a help screen that indicates the D2 SIP specs.

avatar382 commented 13 years ago

We have lots of control over error messages, we just need to catch the error and print a meaningful error message. In this case, the submission should reject with a meaningful reject message. I'll do that.

avatar382 commented 13 years ago

same as #418, closing ticket