daitss / core

DAITSS: Dark Archive In The Sunshine State
GNU General Public License v3.0
9 stars 2 forks source link

Error submitting package undefined method `value' for nil:NilClass #784

Closed szanati closed 7 years ago

szanati commented 8 years ago

I got the following error while submitting a package on both production and ripple:

ERROR Error submitting UF00028315_01045: undefined method `value' for nil:NilClass.

On production the package had rejected last week and UF fixed and resubmitted when it gave the above error.

cchou commented 7 years ago

It took me a while but I was able to locate this problem package on production server, put it on the snow server, http://www.fcla.edu/daitss-test/packages/UF00028315_01045.tar for downloading and troubleshooting purpose.

cchou commented 7 years ago

This package is missing the xref element in the METS file section, hence, daitss error out. I have made changes in DAITSS to dump out more detail error.

The problem section is

it suppose to follow with a METS:flocat with the xref. See the file sec before and after for a correct METS filesec, like this
cchou commented 7 years ago

additional codes have been added to DAITSS so that it will be easier for DAITSS operator which filesec is causing the problem. As an example, here is the new output:

2017-01-01 14:53:31 ERROR Error submitting /Users/cchou/Downloads/packages//UF00028315_01045: error in METS file section, missing xlink:href in element

</METS:file> 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/lib/daitss/proc/sip_archive.rb:369:in block in content_files_with_checksums' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/lib/daitss/proc/sip_archive.rb:366:ineach' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/lib/daitss/proc/sip_archive.rb:366:in map' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/lib/daitss/proc/sip_archive.rb:366:incontent_files_with_checksums' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/lib/daitss/proc/sip_archive.rb:151:in block in validate!' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/lib/daitss/proc/sip_archive.rb:149:inchdir' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/lib/daitss/proc/sip_archive.rb:149:in validate!' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/lib/daitss/proc/sip_archive.rb:92:invalid?' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/lib/daitss/archive/submit.rb:113:in block in submit' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/bundle/ruby/1.9.1/gems/dm-transactions-1.2.0/lib/dm-transactions.rb:373:inblock in transaction' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/bundle/ruby/1.9.1/gems/dm-transactions-1.2.0/lib/dm-transactions.rb:131:in block in commit' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/bundle/ruby/1.9.1/gems/dm-transactions-1.2.0/lib/dm-transactions.rb:195:inwithin' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/bundle/ruby/1.9.1/gems/dm-transactions-1.2.0/lib/dm-transactions.rb:131:in commit' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/bundle/ruby/1.9.1/gems/dm-transactions-1.2.0/lib/dm-transactions.rb:373:intransaction' 2017-01-01 14:53:31 ERROR /opt/web-services/sites/core/lib/daitss/archive/submit.rb:101:in submit' 2017-01-01 14:53:31 ERROR bin/submit-direct:102:insubmit_package' 2017-01-01 14:53:31 ERROR bin/submit-direct:163:in block in <main>' 2017-01-01 14:53:31 ERROR bin/submit-direct:161:ineach' 2017-01-01 14:53:31 ERROR bin/submit-direct:161:in `

'

cchou commented 7 years ago

the code changes have been rolled out to ripple for FDA production staff to better diagnose the sip descriptor.

szanati commented 7 years ago

A fix has been pushed out on 4-6-17. Now the package rejects instead of errors and it shows why the package was rejected.