search

daixiang0 / gci

GCI, a tool that control golang package import order and make it always deterministic.
BSD 3-Clause "New" or "Revised" License
434 stars 63 forks source link

New std lib `unique`,`iter` in go1.23 can not be recognized #209

Open Zxilly opened 4 months ago

Zxilly commented 4 months ago

What version of GCI are you using?

0.13.4

Reproduce Steps

Just run with a file using the unique

What did you expect to see?

unique should be regarded as std lib and stay with other std libs.

What did you see instead?

unique was regarded as third party library.

daixiang0 commented 4 months ago

Refer to https://pkg.go.dev/unique, it is introduced by 1.23rc1, since now 1.23 is not released yet, please wait it.

Zxilly commented 4 months ago

Please take a look at https://github.com/daixiang0/gci/pull/208

Zxilly commented 3 months ago

@daixiang0 Go1.23 has been generally available, please review the PR.

esimonov commented 2 months ago

I believe this can be closed now? It works, including golangci-lint since version 1.61.0.

Zxilly commented 2 months ago

syscall/js still not included