search

dajare / mark-rutherford_mark-rutherfords-deliverance

A Standard Ebooks project
Other
0 stars 0 forks source link

Issues: #1

Closed EmmaSweeney closed 7 months ago

EmmaSweeney commented 7 months ago

General Issues:

epigraph.xhtml:

dajare commented 7 months ago

Thanks for this @EmmaSweeney ! I'll get to this tomorrow (I hope - just shutting down for the night now).

Just a quick comment on removing [Editorial] from that commit - I can/will do, but this is what the Step-by-step guide has under proof-reading:

Printer’s errors. . . . If you spot an obvious error like this that is present in both the transcription and the page scans, it may be a printer’s error that should be corrected in an [Editorial] commit.

I guess this is one of those points where there's been some slippage between guidance and practice! 🤷‍♂️

dajare commented 7 months ago

@EmmaSweeney - Now I check the epigraph language semantics (you're asking for <i ... tags) — lint complains if I put those in <i ... tags which is how I had them originally, probably because they are italicized by the CSS rules in local.css? If you open the file in a browser, you'll see they are italicized.

(And how I got "play" for "book" ?!!)

Could you confirm that you want me to do this? If so, I expect I'll need an se-lint-ignore.xml file, too. Thanks!

Update - Or do you want them in <i... because in the upside-down world of epigraphs, i = regular?! Still odd to me that lint complains..... Confirmation still appreciated! Thanks!

EmmaSweeney commented 7 months ago

I wouldn't mark that printer error as [Editorial] because incorrect quotes happen so often.

In this case, lint is wrong. Half of the text is non-English. You will need to add a se-lint-ignore.xml file.

dajare commented 7 months ago

I've addressed the italics/language issue in epigraph.xhtml — I hope correctly!

If any tweaks are needed, do tell; otherwise if you're content, this is ready for Alex. Thanks for your help!