Closed Aurvandill closed 1 year ago
perhabps i should move the derive_key_pair
Function from the KEM
class to the corresponding KEMPrimitvesInterface
(eg. EC
, X25519
, X448
) subclass.
what's your opinion on that @dajiaji
@dajiaji did you already have time to take a look?
Thanks for your contribution!
I'll check your PR now.
perhabps i should move the
derive_key_pair
Function from theKEM
class to the correspondingKEMPrimitvesInterface
(eg.EC
,X25519
,X448
) subclass. what's your opinion on that @dajiaji
Thanks. I'm very happy if you could move it to the subclasses of KEPrimitivesInterface
.
ok i will move it into the KEMPrimitivesInterface
and revert the version bump later today :)
thanks for taking a look
Attention: 9 lines
in your changes are missing coverage. Please review.
Comparison is base (
bd7748a
) 86.70% compared to head (feb6b1c
) 87.24%. Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@dajiaji I'm done with the changes :)
Thanks for the great work! Approved.
relates to issue #9