Closed honjes closed 5 years ago
Merging #28 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #28 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 76 110 +34
Branches 0 5 +5
=====================================
+ Hits 76 110 +34
Impacted Files | Coverage Δ | |
---|---|---|
src/index.ts | 100% <100%> (ø) |
:arrow_up: |
src/config.ts | 100% <100%> (ø) |
:arrow_up: |
src/matches.ts | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7e621ae...90afb1d. Read the comment docs.
Thanks so much @honjes , I'd be more than happy to support you to make your first contribution. I had the first round of checks, will check it again more in detail after the first iteration.
It seems linke eslint dose not like it when you do not define a type.
I think that this commit is good. Do you have somthing to add ?
I think that this commit is good. Do you have somthing to add ?
I think this is already pretty good, good job. There is just that part that seems a bit fragile, or is it?
Do i have too do somthing too push this pullrequest ?
Do i have too do somthing too push this pullrequest ?
Thank you @honjes for awesome work 🚀🚀🚀 I will bump up the minor version and release it these days.
Extracting Matches constructor into a function. Adding getAllMatches Function to Matches Changing URI-Schema from the getSingleMatch Function to accept only the id of an Match or the complete path. Adding 2 new Test's