search

dajk / hltv-api

DEPRECATED: An unofficial JSON api for popular CS:GO website hltv.org. Check available methods on https://hltv-api.vercel.app/
http://npm.im/hltv-api
MIT License
277 stars 59 forks source link

Add API to get matches by EventId #92

Closed henriqueln7 closed 2 years ago

henriqueln7 commented 2 years ago

This PR adds a parameter eventId on getMatches method to filter matches for a specific event.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hltv-api ✅ Ready (Inspect) Visit Preview Oct 23, 2022 at 4:27PM (UTC)
henriqueln7 commented 2 years ago

Hey, @dajk. Just one question: when will you publish those changes? I can create a specific version to make your job easier if you want :)

dajk commented 1 year ago

Hi @henriqueln7 , I published this with the version 3.0.3, however seems to be broken and I will have to revert and release the new version.

I also had doubts about this function, is this really necessary considering we never had a way to expose an eventId?

henriqueln7 commented 1 year ago

Hey, @dajk. Good question. What you think if we implement a getUpcomingEvents() endpoint or similar? Let me know if you think it is a good ideia, I can work on it :D

dajk commented 1 year ago

Hey, @dajk. Good question. What you think if we implement a getUpcomingEvents() endpoint or similar? Let me know if you think it is a good ideia, I can work on it :D

That would make sense, but also ongoing events would be even more important in my opinion. Unfortunately there is no eventId on the match, we only get the event's name and logo.

henriqueln7 commented 1 year ago

That would make sense, but also ongoing events would be even more important in my opinion. Unfortunately there is no eventId on the match, we only get the event's name and logo.

Sure, I think ongoing events is more important. I can work on it. :)