dajmcdon / rtestim

https://dajmcdon.github.io/rtestim/
Other
4 stars 0 forks source link

Djm/cleanup #10

Closed dajmcdon closed 1 year ago

dajmcdon commented 1 year ago

After merging your #9 I made a lot of changes to clean things up. You should look over this carefully and try to take note of conventions and other issues. A few pointers off the top of my head

For this week, besides continuing to iterate on the code, we need to illustrate this on real data. Please prioritize trying it and handling the resulting bugs (of which I suspect there are many). Try calling the key functions with different arguments and see where it bogs down. Take ownership of this package and dedicate effort toward improvements.

zcaiElvis commented 1 year ago

What do you mean by "code shouldn't run over 80 characters"?

dajmcdon commented 1 year ago

Each line (of code or comments or roxygen documentation) should be at most 80 characters wide. This makes it much easier to view in an editor. If you're working in Rstudio, the editor has a vertical line there if you select the option:

Screenshot 2023-01-22 at 4 03 28 PM
zcaiElvis commented 1 year ago

Noted