dajmcdon / rtestim

https://dajmcdon.github.io/rtestim/
Other
4 stars 0 forks source link

Check `maxiter` #29

Closed dajmcdon closed 1 year ago

dajmcdon commented 1 year ago

In rtestim_path.cpp, the maxiter variable controls the number of iterations per lambda, rather than the total number of iterations. The easiest fix is something like maxiter -= inters, then exit if maxiter < 0. One also needs to eliminate empty solutions (for lambdas we didn't reach) if we stop early.