search

dajobe / raptor

Redland Raptor RDF syntax library
https://librdf.org/raptor/
Other
156 stars 62 forks source link

change "." to ";" in @base statement #19

Closed rhmccullough closed 9 years ago

rhmccullough commented 9 years ago

raptor_internal.h: add world->emit_mkr for use by raptor_turtle_writer_base(). raptor_new_serializer(): set world->emit_mkr tests/mkr/*.mkr: change "." to ";" in expected output files

dajobe commented 9 years ago

-1 I was on my way doing some refactoring when I noticed this. With your change to the tests (and language) so that @base ends in ; not ., my refactored code passes. I'll push it shortly.

dajobe commented 9 years ago

See change in https://github.com/dajobe/raptor/commit/7bccd4460cf92a81afa9bf74db292ddf8dde7b82

rhmccullough commented 9 years ago
  1. writer option is very reasonable. The main reason I didn't go that way was a concern that I might conflict with your existing options.
  2. from my perspective, I thought it would be good for "world" to know the current input and output syntax. AFAIK, it only knows the available options (the factories). PS. After this is done, I am ready to PR the build-formats fix for Cygwin.