dajva / rg.el

Emacs search tool based on ripgrep
https://rgel.readthedocs.io
GNU General Public License v3.0
474 stars 39 forks source link

Allow running rg from Dired on root directory #71

Closed raxod502 closed 4 years ago

raxod502 commented 4 years ago

Previously if you opened a Dired buffer to the root directory of your filesystem and attempted to use rg, rg-project-root would get a nil value for FILE. All of the backends would fail to provide a project root, so rg-project-root would fall back on asking for the directory that contains FILE. Unfortunately, in this case FILE is unset. The problem is solved by handling the cases where FILE is nil (or doesn't have a directory component), and defaulting to default-directory.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.06%) to 83.564% when pulling 5da7d4d0ebee16bf5a7e5750c348aa6081784544 on raxod502:feat/rg-from-root-dired into af1ae5537b5721c15f1d9888a6fb6e146294bfdc on dajva:develop.

dajva commented 4 years ago

Thanks