search

dajva / rg.el

Emacs search tool based on ripgrep
https://rgel.readthedocs.io
GNU General Public License v3.0
471 stars 38 forks source link

rg-mode-map confilct with evil #78

Closed glepnir closed 3 years ago

glepnir commented 4 years ago

How make it work better with evil?

dajva commented 4 years ago

Can you elaborate a bit and be more specific about what problems you see?

b3n commented 4 years ago

I have noticed this too. For some reason it pollutes evil-mode-map-alist with rg.el keybindings even when I am in Evil's normal mode. Every other major-mode I use allows me to use Evil's bindings when I am in normal mode, and the major-mode bindings when I am in insert mode. I have looked at the code and I'm not sure what's causing this.

dajva commented 3 years ago

rg-mode inherits from compilation-mode so this means (I presume) that the result buffer will end up in evil motion mode. Wonder if that has something to do with it. But as you say, you see the same in evil normal mode so maybe it's unrelated. Could it just be that some of the key bindings in this package clash with evils?

dajva commented 3 years ago

Apart from that there are some obvious conflicts with evil motions. I think l and w are the only one that would have to be redefined to work well with evil motions. w is already deprecated but I can do the same with l and then unbind it after 2.0 release.