"f" for "Forward" collides with "Change files" binding

dajva / rg.el

Emacs search tool based on ripgrep

https://rgel.readthedocs.io

GNU General Public License v3.0

471 stars 38 forks source link

"f" for "Forward" collides with "Change files" binding #81

Closed mjs closed 4 years ago

mjs commented 4 years ago

Also fixed doubled up label for history bindings ("Back" was used twice).

mjs commented 4 years ago

I chose some bindings that made sense to me but I'm open to other ideas.

coveralls commented 4 years ago

Coverage remained the same at 83.362% when pulling 72f1f402f440548da458cc15257dfb683c7d48a6 on mjs:fix-history-bindings into e19c06f4c556bda6457da3d50c14b12cb97679d9 on dajva:master.

dajva commented 4 years ago

Oh, how did I miss that. Thanks for fixing it. :)

Some comments:

Still want the labels to be "Back" and "Forward" since that is the terminology that is used throughout the package.
Regarding the bindings, I think we can keep 'b' since that is not taken. I would suggest using 'w' for forward since that may give some kind of mnemonic with 'w' in forward and is also on the left hand to ease the combination with the 'm' menu key. For evil users it's also a familiar binding for moving forward.

mjs commented 4 years ago

Done!

dajva commented 4 years ago

Thanks a lot!