search

dajva / rg.el

Emacs search tool based on ripgrep
https://rgel.readthedocs.io
GNU General Public License v3.0
471 stars 38 forks source link

Add unrestricted option #88

Closed Sasanidas closed 4 years ago

Sasanidas commented 4 years ago

Ripgrep have an option to ignore .gitignore files, sometimes it is useful (at least for me) to use this kind of approach. Thank you

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 83.137% when pulling 737f64487666889428b5b2fe478b911ab1466b47 on Sasanidas:add-option into 87fed01062e9d9b1ecf948cc1997111ee75465fb on dajva:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 83.137% when pulling 737f64487666889428b5b2fe478b911ab1466b47 on Sasanidas:add-option into 87fed01062e9d9b1ecf948cc1997111ee75465fb on dajva:master.

dajva commented 4 years ago

I believe a single --unrestricted is essentially the same as --no-ignore that is a available as a toggle command in the results buffer (bound to i). Is that not enough for your use case?

dajva commented 4 years ago

Oh, just saw that --no-ignore is actually present in the menu as well. There is a bug here lurking though so I am not sure that will stay but I will try to when fixing that bug. So, what remains then is if you are aware of any differences between a single --unrestricted and --no-ignore. My understanding is that they are the same.

Sasanidas commented 4 years ago

Oh, just saw that --no-ignore is actually present in the menu as well. There is a bug here lurking though so I am not sure that will stay but I will try to when fixing that bug. So, what remains then is if you are aware of any differences between a single --unrestricted and --no-ignore. My understanding is that they are the same.

You are right, this is what the documentation say source:

* '-u' is equivalent to '--no-ignore'.
* '-uu' is equivalent to '--no-ignore --hidden'.
* '-uuu' is equivalent to '--no-ignore --hidden --binary'.

So, maybe the option to add would be --binary? Thank you

dajva commented 4 years ago

Sure, add it and I merge it.

dajva commented 4 years ago

The --no-ignore flag should now be handled correctly in the menu with the fix in 6a5700d42b84cee4da16636e987f9d11d9eaf40f.