Bug fixes and improvements

dakala / fullcalendar

Fork of Fullcalendar Drupal 8 module

3 stars 9 forks source link

Bug fixes and improvements #22

Closed lonalore closed 6 years ago

lonalore commented 6 years ago

Got calendar working with Ajax.
Add support for events with recurring date (support for DateRecur module)
Add additional query condition to fullcalendar views for supporting date-ranges
Check 'update' access on the entity for 'editable' option (+add per user caching context)
Ability to open events in a modal window
Fix for changeView/allDay issue
Drupal 8 standards, replaced deprecated function calls

Screenshots

kepernyokep_2017-09-25_15-11-17 kepernyokep_2017-09-25_15-11-36 kepernyokep_2017-09-25_15-11-55

View event (entity) in modal

kepernyokep_2017-09-25_15-46-30

Exposed widgets

peek 2017-09-26 14-09

dakala commented 6 years ago

@lonalore Really appreciate this PR just by looking at the results. Thanks for the effort.

dakala commented 6 years ago

@lonalore Sorry for not getting back to you about this PR sooner. I guess I wasn't too sure where we're checking for the availability of DateRecur module. I can only see in fullcalendar_field_is_date() that we've added date_recur field type.

I'm quite keen to merge this weekend anyway and we can sort out any issues later.

Thanks very much.

lonalore commented 6 years ago

Thank you @dakala We handle the occurances of a recurring field in the "src/Plugin/views/style/FullCalendar.php" file, here: https://github.com/dakala/fullcalendar/pull/22/files#diff-1fd8690943ea0d554bc8d9f9397edd11R421