search

dakala / fullcalendar

Fork of Fullcalendar Drupal 8 module
3 stars 9 forks source link

Manage library downloads #7

Open dakala opened 7 years ago

dakala commented 7 years ago

Using composer or drush - download fullcalendar library and configure path for fullcalendar.settings

acrollet commented 6 years ago

@dakala would you be interested in collaborating on a fullcalendar_library module? Currently for the BAT module we depend on the fullcalendar library and pull it from a CDN if not present. (cf. http://cgit.drupalcode.org/bat/tree/modules/bat_fullcalendar/bat_fullcalendar.module?h=8.x-1.x#n296) This would also resolve #16. If you're interested I'd be happy to submit a PR.

dakala commented 6 years ago

Hi @acrollet. Thanks for this. Do we need a module? It's been a while now since I created this issue but I was thinking of doing it just like in core. I haven't checked but I think they're using core.libraries.yml file for this.

But I'd be interested in a collaboration for this.

acrollet commented 6 years ago

@dakala the major advantage would be in allowing for CDN fallback, which makes setup quicker for site builders and allows use on simplytest.me. (AFAIK this is not possible with a libraries.yml file)

dakala commented 6 years ago

@acrollet That's great. When I was actively working on the module there wasn't a clear way of managing libraries. I can definitely see the advantage of a CDN option. Yes, let's have a solution to start with, please. Thanks.

acrollet commented 6 years ago

Ok, https://www.drupal.org/project/fullcalendar_library is now a thing and I've submitted a PR :)