search

dakanji / G2Project

Community Update of Gallery2 - A web based photo album viewer and editor
Other
7 stars 4 forks source link

Update graphic toolkits to allow the latest version of commands #76

Closed miceno closed 5 years ago

miceno commented 6 years ago

Update to support available app versions for each toolkit:

Closes #73

dakanji commented 6 years ago

So this has crashed and burnt. That's why I asked to wait a little while and work from what was going to be pushed out. Sorry.

The track that will be taken is to

  1. Sort out a Gallery 2 "Minimal" file set
  2. Expand this to a Gallery 2 "Typical" file set
  3. Take on other modules
  4. Look into other stuff

jpegtran is not in the minimal file set but you can push to the G2Project-modules Repo in the meantime if you want.

Idea is to have a structured step wise process with options to add to G2Project-modules and/or G2Project-themes in the interim if desired.

What will be great would be taking on #77 if possible.

Thanks

miceno commented 5 years ago

I am afraid you broke something when merging this... I suggest you undo all the branch merge and I will try to create a separate branch for each of the toolkits, it will be cleaner than this. right now it is a bit of a mess :(

miceno commented 5 years ago

I think it will be better if I take it from here and I will try to solve it. I will create a separate branch for each of the toolkit, there is no need for you to undo the changes, i will take of them. I will do it tomorrow, too late for today in Spain ;)

dakanji commented 5 years ago

Rolled back the changes

miceno commented 5 years ago

Hi, You have alreaady merge the solution to this in #88 , so no need to rollback :)

miceno commented 5 years ago

I am afraid you have broken it again :(

dakanji commented 5 years ago

I am afraid you broke something when merging this... I suggest you undo all the branch merge and I will try to create a separate branch for each of the toolkits, it will be cleaner than this. right now it is a bit of a mess :(

I just followed this!

miceno commented 5 years ago

I prefer we all work on a branch first, test it and then merge onto dev. As of now, working directly on the dev branch, we have broken code in it :(

miceno commented 5 years ago

I am afraid you broke something when merging this... I suggest you undo all the branch merge and I will try to create a separate branch for each of the toolkits, it will be cleaner than this. right now it is a bit of a mess :(

I just followed this!

But there was another message that I will take from here and I will solve it in a separate PR (it was #88 , so I thought you got my second message. I think we need another communication means, it is not working very well through github.

dakanji commented 5 years ago

Sorry about my confusion but there is no reason why Github can't work. All we need to do is make sure we cross reference items.

So for instance, if you added a note to say "This is a separate PR to resolve issues in #xyz" then when I am catching up on your stuff, I will know what your intention is.

I couldn't tell the two items were linked.

I will do the same on my side.

miceno commented 5 years ago

I agree! Let's try it this way :)

dakanji commented 5 years ago

Cool. I will now restore things back to where they where before my reset

miceno commented 5 years ago

Thank you!