dakanji / RefindPlus

A Boot Manager for Mac and PC
GNU General Public License v3.0
320 stars 68 forks source link

Add support for multiple/tertiary supplementary config files #142

Closed 1457384613gh closed 1 year ago

1457384613gh commented 1 year ago

Suggested Feature

Support to include Several secondary .config files.

Example,

config.conf include mouse.conf include icon.conf include menuentry.conf include A.conf include B.conf include C.conf include …

It's more convenient to break up the whole into parts.

Background Information

Or support several tertiary files.

Example,

config.conf include setting.conf

include ….conf

Additional Context

Only one secondary file is not enough.

dakanji commented 1 year ago

Sorry, but while I can see a lot of complexity needed in the code, I can't see what this actually brings to the table. That is, you have not quite explained why it should be done.

I know you have said It's more convenient to break up the whole into parts and that Only one secondary file is not enough. but you haven't explained why it is more convenient to split the parts or why a secondary file is not enough.

What exactly would this permit that is not currently permitted?

dakanji commented 1 year ago

Sorry, but I cannot really see the benefit at this time. If you can convince upstream to implement this however, then it will be added here.

Thanks for the suggestion regardless!

dakanji commented 1 year ago

Yes. rEFInd. i suppose you can try emailing him

dakanji commented 1 year ago

Could help to copy what I said and email Smith?

Sorry, but I can't advocate this. Perhaps you can find someone to help out on that.

You can also try posting on the rEFInd project discussion page. He is not so active on that but ultimately gets around to stuff. Might take some time but I wouldn't say this is a critical item in any case.

dakanji commented 1 year ago

Our national policy does not allow sending private emails to foreigners

Wow. I didn't realise that. He has an account here on GitHub: https://github.com/srs5694 You might be able to reach him there (even if via a different repo)

dakanji commented 1 year ago

I know it is him.

If you don't mind, I will close this now. Good luck!

dakanji commented 1 year ago

rEFInd does allow having a chain of config files but this is due to a bug that has been fixed in RefindPlus. The rEFInd documentation actually states that this is not allowed.

Please post your new unrelated question under Discussions and kindly avoid vandalising existing items in future. Thanks

dakanji commented 1 year ago

rEFInd does allow having a chain of config files but this is due to a bug that has been fixed in RefindPlus. The rEFInd documentation actually states that this is not allowed.

There is a bit of nuance to this.

rEFInd does not indeed allow tertiary configuration files as stated here: https://github.com/dakanji/rEFInd/blob/master/refind.conf-sample#L562-L570 This limitation does not actually work in rEFInd and is the bug fixed in RefindPlus.

Both rEFInd and RefindPlus however allow tertiary include files for manual stanzas. So it is possible to have the following:

# Additional Config File
# Only one is allowed
include config2.conf

# Manual stanza include files
# Multiple are allowed
include manual_stanza_a.conf
include manual_stanza_b.conf
...
include manual_stanza_z.conf

Each of those manual stanza include can have more includes in them

PS: Never used this feature myself but the code supports this although this feature is not documented. I will pay more attention to this undocumented feature and likely to block tertiary includes in the manual include files. That is, multiple manual stanza includes are likely to be maintained but these will not likely be allowed to include others.

1457384613gh commented 1 year ago

Yes, I do so.

It was another bug that made me believe by mistake, that multiple secondary files had been not supported. That is why I issued.

That is a misunderstanding.

github-actions[bot] commented 1 year ago

This thread is being locked.

Please use the Discussions feature for follow on discussion or raise a new issue if appropriate.